Okay, resizing fixes are applied to repo. You don’t need to change the script to apply the changes, I combined them into a single file. It also makes it easier for manual install.
After some testing I can say that install script set everything to a functional and bug-free state. But that does not mean that there aren’t any issues.
The script removes unused files, but there is a way a file will be forgotten.
- Install custom color layout.
- Install default color layout with resizing.
This way glassy-style.css
is still present. It just will be ignored, so it does not affect the currently install.
And now a bit more tricky - I already told it in post 107 (but may not well explained enough). glassy-styles.css
is used for keyboard custom style, but also for Phosh custom style. The Squeekboard custom style contains 3 lines:
@import url("colors/pink-glass.css");
@import url("osk/squeekboard-colors.css");
@import url("osk/scale_1.0_and_2.0/squeekboard_resizing.css");
The Phosh custom style contains those 3 lines:
@import url("colors/pink-glass.css");
@import url("backgrounds/bg001.css");
@import url("styles/glassy-style_phosh.css");
Combined (both styles applied) it contains 5 lines:
@import url("colors/pink-glass.css");
@import url("osk/squeekboard-colors.css");
@import url("osk/scale_1.0_and_2.0/squeekboard_resizing.css");
@import url("backgrounds/bg001.css");
@import url("styles/glassy-style_phosh.css");
You may already see the issue. Installing custom color overwrites this file and removes Phoshs custom style. Removing that file also removes the Phosh custom style. And as you see, both (Phosh and Squeekboard) are using same colors file - removing this also removes colors entirely from Phosh.
Right now the issue only happens to me, since I’m the only person who has the Phosh custom styles. But I want to release those some time later. Could you handle this as with gtk.css
file? Checking if there already exists a file and if so, just adding the lines that are not already in or on remove checking if it contains more @import
rules than those 3 lines and if so, just remove the 2 lines (without color line). Removing no color line also means not to remove the pink-glass.css
file. And removing not the glassy-style.css
means not to remove the line from gtk.css.
Sorry if this is a bit complicated. But after this the install script would be perfect. The installation is a bit more complicated to make it easier for people to modify my work.
Edit:
I will test the uninstall script later.